Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10716 Wrong hash during CSS assets rendering #815

Merged
merged 5 commits into from
Sep 25, 2024
Merged

UHF-10716 Wrong hash during CSS assets rendering #815

merged 5 commits into from
Sep 25, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Sep 25, 2024

UHF-10716

What was done

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh

How to test

  • Clear caches and make sure the public/sites/default/files/css folder is empty
  • Log in and go to f.e. https://helfi-etusivu.docker.so/en/admin/people
    • Check from network tab if you have any redirects in aggregated css files
      image
    • This means that the hashes are incorrect during build and render
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10716 -W
  • Clear the caches again and double check the CSS folder
  • Reload the https://helfi-etusivu.docker.so/en/admin/people and check the network tab for redirects. There shouldn't be any
  • Check that code follows our standards

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch fixes css bundles on my local env. 👍

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants