Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10547 Suunte chat #804

Merged
merged 9 commits into from
Sep 10, 2024
Merged

UHF-10547 Suunte chat #804

merged 9 commits into from
Sep 10, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Sep 6, 2024

UHF-10547

What was done

  • Added dependency injection to ChatLeijuke block.
  • Removed preprocess attribute from genesys_suunte library as that attribute is not handled in ChatLeijuke.php.
  • Added dependency to eu_cookie_compliance library as chat_leijuke.js uses eu_cookie_compliance functions to set the Chat category cookies.
  • Set preprocess: false for chat_leijuke library to prevent possible content loading issues in production environment.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10547

How to test

  • Setup SOTE instance.
  • Remove or comment local.settings.php changes which set the caches to cache.backend.null
  • Make sure the preprocess is set to active
    $config['system.performance']['css']['preprocess'] = 1;
    $config['system.performance']['js']['preprocess'] = 1;
    
  • Clear caches by running drush cr in the app container and verify that the aggregated files have been deleted: ls -lah public/sites/default/files/js and ls -lah public/sites/default/files/css
  • Open your browser (in incognito if you're logged in to sote site), open the network tab from your browser and go to https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/hammashoito
    • Approve the necessary cookies
    • Check from the network tab, that the following files are loaded chat_leijuke.js and genesys_suunte.js
    • Click on the "Hammashoidon chat" button and check that the chat opens normally.
  • Check that code follows our standards

Copy link

sonarqubecloud bot commented Sep 6, 2024

@juho-lehmonen juho-lehmonen self-requested a review September 9, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants