Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9328: Update cookie domains from hel.fi to www.hel.fi #784

Merged
merged 3 commits into from
Jul 2, 2024
Merged

UHF-9328: Update cookie domains from hel.fi to www.hel.fi #784

merged 3 commits into from
Jul 2, 2024

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Jul 2, 2024 •
edited by jira bot
Loading

UHF-9328

What was done

Updates cookie domains (and descriptions) from hel.fi to www.hel.fi.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9328-update-cookie-domains
  • Run make drush-updb drush-cr

How to test

  • Go to /en/cookie-information-and-settings and check that all instances of hel.fi have been changed to www.hel.fi in the provider and purpose columns.
  • Same should apply to the FI and SV translations.
  • Check that code follows our standards

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@juho-lehmonen juho-lehmonen merged commit 81f237a into main Jul 2, 2024
1 of 4 checks passed
@juho-lehmonen juho-lehmonen deleted the UHF-9328-update-cookie-domains branch July 2, 2024 08:15
This was referenced Jul 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juho-lehmonen @teroelonen