Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10159 Convert fields to translatable fields #768

Merged
merged 1 commit into from
May 29, 2024
Merged

UHF-10159 Convert fields to translatable fields #768

merged 1 commit into from
May 29, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented May 29, 2024

UHF-10159

What was done

  • Make the announcement title and TPR unit phone label translatable

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10159
  • Run make drush-updb drush-cr

How to test

  • Check that the assistive title for the announcement (field name: Announcement title) is translatable
  • Check that the phone label under the TPR unit's "Move phone to Other contact information accordion" boolean field is also translatable
  • Check that code follows our standards

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very nicely 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants