Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9980: Duplicate/missing <br /> tags. #758

Merged
merged 4 commits into from
May 15, 2024
Merged

UHF-9980: Duplicate/missing <br /> tags. #758

merged 4 commits into from
May 15, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented May 14, 2024

UHF-9980

What was done

<br /> tags are missing from this page. This is caused by faulty patch https://www.drupal.org/project/drupal/issues/3083786#comment-15468418. Without the patch, this page would have too many <br /> tags, since core filter does not recognize variations of the tags (<br/>, <br>, <br some-attribute="..." />, etc.).

Related core issue: https://www.drupal.org/project/drupal/issues/3083786.

Related: UHF-9952.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9980-br-tags
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Continuous documentation

  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@hyrsky hyrsky force-pushed the UHF-9980-br-tags branch 2 times, most recently from cb49ba9 to d4d3b9d Compare May 14, 2024 08:13
@hyrsky hyrsky force-pushed the UHF-9980-br-tags branch from d4d3b9d to 5ff07b3 Compare May 14, 2024 10:01
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants