UHF-9738: Fix block access hook

[hyrsky]

UHF-9738

What was done

• Changes to hook_block_access made in UHF-9738: news article content type #735 broke nodes where field_has_hero was FALSE but field_hero was not.
  • Remove support for field_hero without field_has_hero since that was not used by news_article nodes.
  • Simplify title block hiding logic throughout the code base.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the Helfi Platform config
  • composer require drupal/helfi_platform_config:dev-UHF-9738-block-access-fixes
• Run make drush-updb drush-cr

How to test

• Check that this feature works
• Check that code follows our standards

Continuous documentation

• This feature has been documented/the documentation has been updated
• [?] This change doesn't require updates to the documentation

Translations

• Translations have been added to .po -files and included in this PR

Other PRs

• UHF-9738: Move block visibility to access hook drupal-hdbt#982
• UHF-X: block access fixes drupal-helfi-etusivu#605

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud