Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Select icon library #721

Merged
merged 11 commits into from
Mar 26, 2024
Merged

UHF-X Select icon library #721

merged 11 commits into from
Mar 26, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 26, 2024

What was done

  • Attached the hdbt_admin_tools/select_icon library to the select icon widget template.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_select_icon_library
  • Run make drush-cr

How to test

  • Create a hero and check that the Icon selection tool works
  • Check that code follows our standards

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.53%. Comparing base (dee862a) to head (de0ab50).
Report is 2 commits behind head on main.

❗ Current head de0ab50 differs from pull request most recent head bffd57e. Consider uploading reports for the commit bffd57e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #721   +/-   ##
=========================================
  Coverage     14.53%   14.53%           
  Complexity      256      256           
=========================================
  Files            30       30           
  Lines           977      977           
=========================================
  Hits            142      142           
  Misses          835      835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes many issues 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants