Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9530: Linked events keywords #710

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Mar 11, 2024

UHF-9530

What was done

  • Add keyword filter to event_list paragraph.
  • I chose to migrate all keywords to Drupal since they don't appear to change that often. Only two keywords have their changed timestamp in 2020s.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9530-linked-events-keywords'
    • composer require drupal/hdbt:dev-UHF-9530-linked-events-keywords
  • Run make drush-updb drush-cr

How to test

  • Run drush mim linked_events_keywords --reset-threshold 1
  • Edit any page with event_list paragraph. You should see select element with linked events keywords.
  • If some keywords are selected, keyword filter should be visible.
  • Test keyword filter.
  • Check that code follows our standards

Other PRs

@hyrsky hyrsky force-pushed the UHF-9530-linked-events-keywords branch from a1ce579 to c1234d8 Compare March 11, 2024 06:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.01%. Comparing base (d5d63d6) to head (42b7c53).
Report is 8 commits behind head on main.

❗ Current head 42b7c53 differs from pull request most recent head 0b559d2. Consider uploading reports for the commit 0b559d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #710   +/-   ##
=========================================
  Coverage     13.01%   13.01%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           945      945           
=========================================
  Hits            123      123           
  Misses          822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juho-lehmonen juho-lehmonen self-requested a review March 11, 2024 11:06
juho-lehmonen

This comment was marked as outdated.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants