Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8835 Accordion translations #698

Merged
merged 4 commits into from
Feb 26, 2024
Merged

UHF-8835 Accordion translations #698

merged 4 commits into from
Feb 26, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 26, 2024

UHF-8835

What was done

  • Updated texts and translations for accordion and accordion items.
  • Added a preprocess hook to change the 'Add accordion item' button text to 'Accordion item'.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8835
  • Run make drush-updb drush-cr

How to test

  • Change your logged in user Administration pages language to Finnish
  • Go to create a new Accordion paragraph
  • Check that all of the texts and translations mentioned in the task have been changed
  • Check that code follows our standards

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.07%. Comparing base (4f4c6fa) to head (4e13d9c).
Report is 3 commits behind head on main.

❗ Current head 4e13d9c differs from pull request most recent head 6c52d50. Consider uploading reports for the commit 6c52d50 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #698   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           941      941           
=========================================
  Hits            123      123           
  Misses          818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants