Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9584: Genesys-chat style fixes and hacks to mitigate issues when using the chat #694

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 16, 2024

UHF-9584

What was done

  • The genesys chat has a css-file that overrides the default styles provided by the chat. The styles are horrible and very buggy but I added some improvements and the usability of the chat should be now a bit better than before. But this is no way any master piece and this hopefully will be replaced with Telia Chat in the near future so we won't use too much time on this.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9584
  • Run make drush-cr

How to test

  • Testing this one is a bit tricky. To test this you actually need to open a chat to the dentists office and this of course bothers the customer service since there can be only two chats open at the same time. Also the chat is open from Monday - Friday at 8:00-15:00. So when testing be quick :)
  • Open the chat and write some long text to the textarea so that it goes to multiple lines. Previously the last lines of your text would be hidden so that you can only see a small part of them. Check the picture:
chat_bug
  • Now with these css changes you should be able to use the textarea so that you last lines won't be hidden under the browser.
  • There is also small changes for the layout of the chat to make it look less shitty like having the avatar icons on the left for the customer service person and on the right for your avatar. On the previous implementation your avatar would not always be attached to the right but it would move to center if your message was short.
  • Check that code follows our standards

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7a3a5e) 13.07% compared to head (83537f0) 13.07%.
Report is 2 commits behind head on main.

❗ Current head 83537f0 differs from pull request most recent head 4bf2d9a. Consider uploading reports for the commit 4bf2d9a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #694   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           941      941           
=========================================
  Hits            123      123           
  Misses          818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants