Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9311: Unit search paragraph changes and improvements #686

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 6, 2024

UHF-9311

What was done

  • Change the default values of Unit Search fields Search label and Search button text so that they come from code.
  • Add new optional field Additional description under the search input (field_unit_search_meta_desc)
  • Change Search description field to compulsory.
  • Adjust the labels and descriptions on the admin side of the paragraph.

How to install

  • Make sure your instance is up and running on latest dev branch. You can test this for example with KUVA instance.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9311
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9311
  • Run make drush-updb drush-cr drush-locale-update drush-cr

How to test

  • The update helfi_tpr_config_update_9055() should be now successfully run.
  • Go to the site and try adding a new unit search for example to https://helfi-kuva.docker.so/en/culture-and-leisure/node/add/landing_page. Make sure the field labels and descriptions match to the UHF-9311 tables values.
  • Make sure the Metatiedot fields don't have any default values and that there is the new Additional description under the search input field present.
  • Add some testing information for the Unit Search but leave the Metatiedot empty. Save the unit search and make sure that there is default values provided to the Search input label (Name, address or postal code), Search button (Search) and the singular (result) and plural results (results).
  • Now go to edit the Unit Search again and add some values for the previously empty Metatiedot. Save and make sure the values you input to the fields are used.
  • Check that code follows our standards.

Other PRs

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c6632b) 13.07% compared to head (ab09982) 13.07%.
Report is 2 commits behind head on main.

❗ Current head ab09982 differs from pull request most recent head 49d2d78. Consider uploading reports for the commit 49d2d78 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #686   +/-   ##
=========================================
  Coverage     13.07%   13.07%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           941      941           
=========================================
  Hits            123      123           
  Misses          818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants