Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9551: Telia ACE fixes. #681

Merged
merged 4 commits into from
Apr 25, 2024
Merged

UHF-9551: Telia ACE fixes. #681

merged 4 commits into from
Apr 25, 2024

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Jan 29, 2024

UHF-9551

What was done

Create Telia ACE embed block. Change embed method to always use the load_ace.js script.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9551-telia-ace-fixes
  • Run make drush-updb drush-cr

How to test

  • Add a Telia ACE block to a standard or landing page with the following IDs. Use block translation to set up the finnish and swedish IDs. Also add english, finnish and swedish translations for the node.
    • EN: helsinki-testichat_en
    • FI: helsinki-testichat_fi
    • SV: helsinki-testichat_sv
  • Before you load the test page, make sure you've only accepted necessary cookies. Chat cookies should be disabled
  • When you first load the page the block was added on, make sure it doesn't add any cookies or local- / sessionstorage data (there's a separate ticket for more in depth auditing, but would be good to double check this here too)
  • When you click the chat button it should (eventually) load the chat widget and open it automatically
    • It might take a few seconds to load and it might print errors in the console log, but that's expected
  • Open different language veresions of the page. Make sure it opens localized versions of the chat widget
  • Check the cookie information page. The chat cookies should now be accepted
  • Check that code follows our standards.

@juho-lehmonen juho-lehmonen marked this pull request as draft January 29, 2024 06:49
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juho-lehmonen juho-lehmonen force-pushed the UHF-9551-telia-ace-fixes branch from a121362 to 40b9f02 Compare April 22, 2024 11:44
@juho-lehmonen juho-lehmonen force-pushed the UHF-9551-telia-ace-fixes branch from 52c923c to 6792bac Compare April 24, 2024 08:08
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juho-lehmonen juho-lehmonen changed the title Draft: UHF-9551: Telia ACE fixes. UHF-9551: Telia ACE fixes. Apr 24, 2024
@juho-lehmonen juho-lehmonen marked this pull request as ready for review April 24, 2024 10:07
@juho-lehmonen juho-lehmonen requested a review from rpnykanen April 25, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants