-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-9274: Change Telia ACE widget embed element #659
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
============================================
- Coverage 13.15% 13.07% -0.09%
Complexity 241 241
============================================
Files 28 28
Lines 935 941 +6
============================================
Hits 123 123
- Misses 812 818 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving "Display title" selection activated causes a huge white block under footer.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
UHF-9274
What was done
How to install
git pull origin dev
make fresh
composer require drupal/helfi_platform_config:dev-UHF-9274-telia-ace-button-improvement
make drush-cr
How to test
<div class="hidden" id="humany_local-chat-asiointi"></div>
element is thereACEWebSDK.min.js
script is embedded on the page and has theasync
parameterwindow.chat_user_consent
object is available on the page