Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Views configuration translations #655

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 29, 2023

What was done

  • Updated every view and view translation via UI and then exported configuration

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_views_translations
  • Run make drush-updb drush-cr

How to test

  • After the instance update is finished, run make drush-cex and go through each configuration. Check that the configuration change makes sense (I.e compare the change to configuration changes in this PR)
  • Check that the updated feature still works as before
  • Check that code follows our standards

@codecov-commenter
Copy link

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6b8c6d7) 13.03% compared to head (5152d45) 13.01%.
Report is 10 commits behind head on main.

❗ Current head 5152d45 differs from pull request most recent head c67b3bb. Consider uploading reports for the commit c67b3bb to get more accurate results

Files Patch % Lines
src/Plugin/Block/ChatLeijuke.php 0.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #655      +/-   ##
============================================
- Coverage     13.03%   13.01%   -0.03%     
  Complexity      241      241              
============================================
  Files            28       28              
  Lines           928      930       +2     
============================================
  Hits            121      121              
- Misses          807      809       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked as it should on KASKO-instance, great work!! 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants