Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9249: Description override field for tpr units #653

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Nov 28, 2023

UHF-9249

School don't have description field coming from TPR so they need a new field for adding the description in the Drupal.

What was done

  • New field, enrich_description, has been added in all instances.

How to install

  • Make sure your instance (preferably kasko) is up and running on latest dev branch.
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9249_description-override
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9249_description-override
  • Run make drush-updb drush-cr drush-locale-update drush-cr

How to test

  • Go edit any school (e.g. https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/aleksis-kiven-peruskoulu) and check that there is a new field Long description (replacing missing information).
  • Check that the field label and description is translated correctly to Finnish and Swedish, probably need to switch user's preferred UI language. For some reason updating translations work randomly, so this might be a tough step.
  • Add text to the Long description (replacing missing information) field and save the page. Check that the field content is displayed like a description normally on the unit's page.
  • Test also other TPR unit than school, e.g. this daycare unit. The new description field should not override what is coming from the TPR. Instead, the new description field should be displayed only if the data from TPR is missing.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c1c831) 13.75% compared to head (19e37be) 13.07%.
Report is 109 commits behind head on main.

❗ Current head 19e37be differs from pull request most recent head b2e9059. Consider uploading reports for the commit b2e9059 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #653      +/-   ##
============================================
- Coverage     13.75%   13.07%   -0.68%     
- Complexity      238      241       +3     
============================================
  Files            27       28       +1     
  Lines           880      941      +61     
============================================
+ Hits            121      123       +2     
- Misses          759      818      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dire dire requested review from teroelonen and removed request for Arkkimaagi December 20, 2023 13:06
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well, great work 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants