Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8936: Enable text and map paragraphs for lower content of TPR units #650

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Nov 23, 2023

UHF-8936

What was done

  • Enabled text and map paragraphs for the lower content of TPR units

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8936_tpr-unit-text-and-map
  • Run make drush-updb drush-cr

How to test

  • Add text and map paragraphs to any TPR page.
  • Check that the text and map paragraphs look like they should.
  • Check that code follows our standards

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ee2c0) 13.75% compared to head (7eadadf) 13.75%.

❗ Current head 7eadadf differs from pull request most recent head abf0ce6. Consider uploading reports for the commit abf0ce6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #650   +/-   ##
=========================================
  Coverage     13.75%   13.75%           
  Complexity      238      238           
=========================================
  Files            27       27           
  Lines           880      880           
=========================================
  Hits            121      121           
  Misses          759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants