Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the todo-commented code with proper service implemention #645

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

rpnykanen
Copy link
Contributor

update the todo-commented code with proper service implemention

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ee2c0) 13.75% compared to head (811cae0) 13.75%.

❗ Current head 811cae0 differs from pull request most recent head ee11b91. Consider uploading reports for the commit ee11b91 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #645   +/-   ##
=========================================
  Coverage     13.75%   13.75%           
  Complexity      238      238           
=========================================
  Files            27       27           
  Lines           880      880           
=========================================
  Hits            121      121           
  Misses          759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works! 🦜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants