-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8720: update cookies #624
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=========================================
Coverage 13.75% 13.75%
Complexity 238 238
=========================================
Files 27 27
Lines 880 880
=========================================
Hits 121 121
Misses 759 759 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job with the documentation! 🥇
However there seems to be something 🐟 in the allowed_cookies. Can you check it out?
modules/helfi_eu_cookie_compliance/config/rewrite/eu_cookie_compliance.settings.yml
Outdated
Show resolved
Hide resolved
26131b4
to
27d55a4
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to be merged. Good job! 🚀
@Jussiles As a reminder; We need to rebuild the cookie explanations when the 4.x branch and/or tags based on that branch have been released. The markup of the |
Kudos, SonarCloud Quality Gate passed!
|
UHF-8720
UHF-9223
What was done
GUEST_LANGUAGE_ID
How to install
git pull origin dev
make fresh
make drush-cr
composer require drupal/helfi_platform_config:dev-UHF-8720-update-cookies
make drush-updb drush-cr
How to test