Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8720: update cookies #624

Merged
merged 7 commits into from
Nov 28, 2023
Merged

UHF-8720: update cookies #624

merged 7 commits into from
Nov 28, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Oct 25, 2023

UHF-8720

UHF-9223

What was done

  • Remove outdated cookies from cookie settings
  • Remove marketing cookie category
  • Add new cookie: GUEST_LANGUAGE_ID
  • Update cookie policy version to 1.2.0

How to install

  • Make sure Strategia instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
    • make drush-cr
  • Go to the site and give full cookie consent when cookie banner appears. It's still the old cookie policy version. You need to give consent so you're able to test that cookie banner will reappear after cookie policy version is increased.
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8720-update-cookies
  • Run make drush-updb drush-cr

How to test

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b892c3) 13.75% compared to head (32d2a19) 13.75%.

❗ Current head 32d2a19 differs from pull request most recent head 78db1bb. Consider uploading reports for the commit 78db1bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #624   +/-   ##
=========================================
  Coverage     13.75%   13.75%           
  Complexity      238      238           
=========================================
  Files            27       27           
  Lines           880      880           
=========================================
  Hits            121      121           
  Misses          759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job with the documentation! 🥇
However there seems to be something 🐟 in the allowed_cookies. Can you check it out?

@Jussiles Jussiles force-pushed the UHF-8720-update-cookies branch from 26131b4 to 27d55a4 Compare October 26, 2023 05:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to be merged. Good job! 🚀

@khalima
Copy link
Contributor

khalima commented Nov 2, 2023

@Jussiles As a reminder; We need to rebuild the cookie explanations when the 4.x branch and/or tags based on that branch have been released. The markup of the <table> tags will change to <figure><table>

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants