Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-5855: Added icons for the paragraphs #623

Merged
merged 1 commit into from
Oct 24, 2023
Merged

UHF-5855: Added icons for the paragraphs #623

merged 1 commit into from
Oct 24, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 24, 2023 •
edited by jira bot
Loading

UHF-5855

What was done

  • Added icons for the paragraphs

How to install

  • Make sure your kymp instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-5855_paragraphs_icons
  • Run make drush-updb drush-cr

How to test

  • Go to create a landing page and a standard page and check that there are no missing paragraph icons when you click on the paragraph selection button 👇

image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

teroelonen
teroelonen approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look really nice 🦖

@khalima khalima merged commit 3fc6a55 into main Oct 24, 2023
4 checks passed
@khalima khalima deleted the UHF-5855_paragraphs_icons branch October 24, 2023 19:15
This was referenced Oct 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen