Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Fixed update of helfi_toc module #622

Merged
merged 1 commit into from
Oct 20, 2023
Merged

UHF-X Fixed update of helfi_toc module #622

merged 1 commit into from
Oct 20, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Oct 20, 2023

UHF-X

The helfi_toc_update_9002 update fails if the helfi_tpr module is not installed in the instance.

What was done

  • Added a check if the module is installed.

How to install

  • Make sure your etusivu instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_fix-toc-update
  • Run make drush-updb drush-cr

How to test

  • Check that the update runs smoothly in etusivu instance.
  • Extra points if you test that the update still runs nicely on an instance with helfi_tpr enabled.
  • Check that code follows our standards

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dire dire marked this pull request as ready for review October 20, 2023 06:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #622 (efc0f66) into main (a382779) will not change coverage.
The diff coverage is n/a.

❗ Current head efc0f66 differs from pull request most recent head 19848bb. Consider uploading reports for the commit 19848bb to get more accurate results

@@            Coverage Diff            @@
##               main     #622   +/-   ##
=========================================
  Coverage     13.29%   13.29%           
  Complexity      241      241           
=========================================
  Files            30       30           
  Lines           910      910           
=========================================
  Hits            121      121           
  Misses          789      789           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants