Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8932: Sidebar content and TPR unit config changes #605

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Sep 29, 2023

UHF-8932

  • TPR unit page design has changed. Has affects to the sidebar content.

What was done

  • Removed unit contact information from the sidebar.
  • Added latitude and longitude fields to unit display settings.

How to install

  • For full install/testing see other PR's section
  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8932_Unit_layout_changes
  • Run make drush-updb drush-cr

How to test

  • Check that code follows our standards

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #605 (f5e610e) into main (1ff227d) will increase coverage by 0.11%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

❗ Current head f5e610e differs from pull request most recent head 20f429c. Consider uploading reports for the commit 20f429c to get more accurate results

@@             Coverage Diff              @@
##               main     #605      +/-   ##
============================================
+ Coverage     13.18%   13.29%   +0.11%     
+ Complexity      243      241       -2     
============================================
  Files            30       30              
  Lines           918      910       -8     
============================================
  Hits            121      121              
+ Misses          797      789       -8     
Files Coverage Δ
src/Plugin/Block/LowerContentBlock.php 0.00% <ø> (ø)
src/Plugin/Block/SidebarContentBlock.php 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xkhaven xkhaven marked this pull request as ready for review October 6, 2023 10:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are good to go 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants