Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9020 hearing api url #602

Merged
merged 2 commits into from
Sep 27, 2023
Merged

UHF-9020 hearing api url #602

merged 2 commits into from
Sep 27, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Sep 27, 2023

UHF-9020

Hearings api was moved and the url changed.

What was done

Updated the api url.
Updated logging.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9020
  • Run make drush-updb drush-cr

How to test

  • Add a hearings paragraph to any landing page and save it

  • Load the landing page

  • The page should load normally and the paragraph should be visible with either:

    • a list of active hearings
    • "no hearings found" -message
  • Check the updated url from the readme, copy the api url and see that the url works on your browser

  • Compare the url to the one in Hearings.php API_URL constant

    • the constant's value should match the url you tried in your browser
  • Check that this feature works
  • Check that code follows our standards

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job acknowledging the bug! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants