Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old domains for auth URLs in chats #593

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

dire
Copy link
Contributor

@dire dire commented Sep 20, 2023

UHF-8981

The new domain for genesys chat services doesn't work in the authentication URLs.

What was done

  • Reverted the changed domains but only the URLs that have /chat/tunnistus in them.

How to install

  • Make sure your sote instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8981_Use-old-chat-auth-domains
  • Run make drush-cr

How to test

  • Check the code changes: chat-proxy.hel.fi domains should have been changed to asiointi.hel.fi.

@dire dire changed the title Use old domains for auth URLs in Suunte. Use old domains for auth URLs in chats Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #593 (a02040d) into main (af36011) will not change coverage.
The diff coverage is n/a.

❗ Current head a02040d differs from pull request most recent head 2bdfe85. Consider uploading reports for the commit 2bdfe85 to get more accurate results

@@            Coverage Diff            @@
##               main     #593   +/-   ##
=========================================
  Coverage     12.74%   12.74%           
  Complexity      236      236           
=========================================
  Files            30       30           
  Lines           902      902           
=========================================
  Hits            115      115           
  Misses          787      787           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
44.4% 44.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants