Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8717: Add field for hiding automatic service point listing #587

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Sep 15, 2023

UHF-8717

A feature to hide service points is needed.

What was done

  • Added a checkbox field for hiding the service points.
  • Added translations for the new field label and description.
  • Added a helper variable for use in the twigs.

How to install

  • Make sure your instance (any instance with tpr_service content) is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the hdbt theme and platform config
    • composer require drupal/hdbt:dev-UHF-8717_Hiding-service-points
    • composer require drupal/helfi_platform_config:dev-UHF-8717_Hiding-service-points
  • Run make drush-updb drush-cr drush-local-update

How to test

  • Check that the updb runs nicely.
  • Open a tpr service page that has a list of services in the bottom of the page. Go edit the page and see the new checkbox "Hide service points".
  • Check that the translations for the checkbox label and description work (might need to change the UI language from the user's settings)
  • Check that code follows our standards.
  • Check the other PR.

Troubleshooting

  1. Translations don't apply? Try running drush cr; drush locale:update separately without the locale:check etc.

Other PRs

@dire dire changed the title UHF-8717: Add a helping variable for hiding the service points. UHF-8717: Add field for hiding automatic service point listing Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #587 (bad38b1) into main (90394a0) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head bad38b1 differs from pull request most recent head 465089f. Consider uploading reports for the commit 465089f to get more accurate results

@@            Coverage Diff            @@
##               main     #587   +/-   ##
=========================================
  Coverage     12.74%   12.74%           
  Complexity      236      236           
=========================================
  Files            30       30           
  Lines           902      902           
=========================================
  Hits            115      115           
  Misses          787      787           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dire dire requested a review from hyrsky September 21, 2023 04:50
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, works as expected. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants