Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8564: Remove unwanted and unused allowed html from text-formats #578

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Sep 5, 2023

UHF-8564

What was done

  • Removed unwanted and unused allowed html from text-formats.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8564
  • Run make drush-updb drush-cr

How to test

  • Go to /admin/config/content/formats and check the that the html and minimal text formats are now in line with the new configuration. Its easiest to see what has changed from the diff on "Files changed" tab.
  • Testing this thoroughly would require siteimprove searches for the content to see if the things that are removed affect the current content. I think it is up to the tester to decide what to test. There is some content that will be removed if the content that is breaking these new rules is saved but the breaking will be minimal and in places where there is things pasted from other sources without thinking.
  • Check that code follows our standards

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants