-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8514: Add patch for simple_sitemap module. #572
UHF-8514: Add patch for simple_sitemap module. #572
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
=========================================
Coverage 12.74% 12.74%
Complexity 236 236
=========================================
Files 30 30
Lines 902 902
=========================================
Hits 115 115
Misses 787 787 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sitemap diff with this branch:
197,200c197,200
< <loc>https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus</loc>
< <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus"/>
< <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning/fostran-och-utbildning"/>
< <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education/childhood-and-education"/>
---
> <loc>https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus</loc>
> <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus"/>
> <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning"/>
> <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education"/>
205,208c205,208
< <loc>https://helfi-kasko.docker.so/sv/fostran-och-utbildning/fostran-och-utbildning</loc>
< <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus"/>
< <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning/fostran-och-utbildning"/>
< <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education/childhood-and-education"/>
---
> <loc>https://helfi-kasko.docker.so/sv/fostran-och-utbildning</loc>
> <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus"/>
> <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning"/>
> <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education"/>
213,216c213,216
< <loc>https://helfi-kasko.docker.so/en/childhood-and-education/childhood-and-education</loc>
< <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus"/>
< <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning/fostran-och-utbildning"/>
< <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education/childhood-and-education"/>
---
> <loc>https://helfi-kasko.docker.so/en/childhood-and-education</loc>
> <xhtml:link rel="alternate" hreflang="fi" href="https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus"/>
> <xhtml:link rel="alternate" hreflang="sv" href="https://helfi-kasko.docker.so/sv/fostran-och-utbildning"/>
> <xhtml:link rel="alternate" hreflang="en" href="https://helfi-kasko.docker.so/en/childhood-and-education"/>
UHF-8514
What was done
This PR adds a patch to fix frontpage handling in sitemap.xml.
Replicate issue
git pull origin dev
make fresh
https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus
https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/avoimet-tyopaikat
https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne/kaupunkiymparisto-ja-liikenne
How to install fix
composer require drupal/helfi_platform_config:dev-UHF-8514-patch-sitemap-to-fix-frontpage-urls
composer install
again, you should see this output:Applying patches for drupal/simple_sitemap https://www.drupal.org/files/issues/2022-02-15/3264573-2.patch
drush cr
How to test
https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/kasvatus-ja-koulutus
https://helfi-rekry.docker.so/fi/avoimet-tyopaikat
https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne