Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8524: Fix news list params #559

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Jul 24, 2023

UHF-8524

Fix linking to news archive app from news list paragraph

What was done

  • Added fields to external entities to read frontpage tid for terms
  • Added reading jsonapi response into aforementioned fields
  • Fixed news list preprocess to include tids instead of term names

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8524-fix-news-list-params
  • Run make drush-updb drush-cr

How to test

  • Check if your instance uses news list paragraph on it's frontpage (a lot of the instances do) or if you know a page where it's used, check that one
  • ...or just make a landing page, add news_list paragraph, add some terms to it and view the page
  • The link below the news list should link correctly to news archive page using term IDs instead of term names

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #559 (2a15bd7) into main (70ef115) will not change coverage.
The diff coverage is n/a.

❗ Current head 2a15bd7 differs from pull request most recent head b90520e. Consider uploading reports for the commit b90520e to get more accurate results

@@            Coverage Diff            @@
##               main     #559   +/-   ##
=========================================
  Coverage     12.74%   12.74%           
  Complexity      236      236           
=========================================
  Files            30       30           
  Lines           902      902           
=========================================
  Hits            115      115           
  Misses          787      787           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works correctly 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants