Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8595: Revert unit display configs #542

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Jun 27, 2023

UHF-8595

These config changes are wanted only in KUVA instance.

What was done

  • Reverted changes in the tpr_unit display configs.

How to install and test

  • Mostly just check the config changes. Following fields shouldn't be enabled anymore for the view display:
    • other_info
    • price_info
    • contacts
    • links

If you prefer to actually test

  • Make sure your instance (something else than kuva) is up and running
    • composer require drupal/helfi_platform_config:dev-UHF-8595_Revert-unit-display-config-changes
    • make fresh
  • Run make drush-updb drush-cr
  • Check that the four fields (Further information, Charges, Other contact information and Web sites) are not displayed on TPR Unit pages: /admin/structure/tpr_unit/settings/display.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #542 (bb78d63) into main (6152bde) will not change coverage.
The diff coverage is n/a.

❗ Current head bb78d63 differs from pull request most recent head 425dbd2. Consider uploading reports for the commit 425dbd2 to get more accurate results

@@            Coverage Diff            @@
##               main     #542   +/-   ##
=========================================
  Coverage     12.33%   12.33%           
  Complexity      237      237           
=========================================
  Files            31       31           
  Lines           932      932           
=========================================
  Hits            115      115           
  Misses          817      817           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants