Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8616 translatable menu link uri D10 #536

Merged
merged 5 commits into from
Jun 26, 2023
Merged

UHF-8616 translatable menu link uri D10 #536

merged 5 commits into from
Jun 26, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jun 16, 2023

UHF-8616

The translatable_menu_link_uri contrib module does not have D10 compatibility yet

What was done

Created a patch based on upgrade status module report

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8616
  • Run make drush-updb drush-cr

How to test

  • composer require drupal/upgrade_status
  • drush en upgrade_status
  • drush us-a translatable_menu_link_uri

The report should say everything is ok.
(optional) Edit and save menu link. Should work normally.

@juho-lehmonen juho-lehmonen self-requested a review June 16, 2023 06:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #536 (dff09f8) into main (74e34d6) will not change coverage.
The diff coverage is n/a.

❗ Current head dff09f8 differs from pull request most recent head 9dcc862. Consider uploading reports for the commit 9dcc862 to get more accurate results

@@            Coverage Diff            @@
##               main     #536   +/-   ##
=========================================
  Coverage     12.33%   12.33%           
  Complexity      237      237           
=========================================
  Files            31       31           
  Lines           932      932           
=========================================
  Hits            115      115           
  Misses          817      817           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants