Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Remove references to handorgel library that is no longer used #533

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 8, 2023

UHF-X

What was done

  • Remove references to handorgel library that is no longer used from table of contents functionality.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_hdbt_cleanup drupal/hdbt:dev-UHF-X_hdbt_cleanup
  • Run make drush-updb drush-cr

How to test

  • Check that table of content functionality still works as it used to.
  • Check that code follows our standards

Other PRs

@codecov-commenter
Copy link

Codecov Report

Merging #533 (ff82962) into main (e1f7882) will not change coverage.
The diff coverage is n/a.

❗ Current head ff82962 differs from pull request most recent head ee2a0a5. Consider uploading reports for the commit ee2a0a5 to get more accurate results

@@            Coverage Diff            @@
##               main     #533   +/-   ##
=========================================
  Coverage     12.33%   12.33%           
  Complexity      237      237           
=========================================
  Files            31       31           
  Lines           932      932           
=========================================
  Hits            115      115           
  Misses          817      817           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…tableOfContents.js so that the h2 accordion headers inside accordion paragraphs won't be added to the toc
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants