-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-X Missing paragraphs #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuutti
approved these changes
Apr 14, 2023
helfi_platform_config.module
Outdated
* Base field override or field config. | ||
*/ | ||
function helfi_platform_config_rebuild_handler_settings( | ||
BaseFieldOverride|FieldConfigInterface $field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseFieldOverride implements FieldConfigInterface, so I assume BaseFieldOverride type hint is unnecessary
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
How to install
git pull origin dev
make fresh
composer require drupal/helfi_platform_config:dev-UHF-X_missing_paragraphs
make shell
and rundrush eval "module_load_include('install', 'helfi_base_content', 'helfi_base_content'); helfi_base_content_update_9001();"
How to test