UHF-8290 getCurrentLanguage parameter #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnouncementBlock.php: using type_content on block build method.
Add new announcement with only finnish language. Add another with only english language. You should see the correct announcement always.
paragraphs_news_list_preprocess: using type_content on preprocess.
Add news list paragraph to content (multiple translations). The urls pointing to front-page instance's news archive should
have correct url + lang code.
LinkedEvents.php: using type_content on requests language parameter.
Add events paragraph to a page. Fill the info (url for example https://tapahtumat.hel.fi/en/events?text=jooga).
The content should be on correct language.
React and share: using type_content on block's build method.
Make sure you have REACT_AND_SHARE_APIKEY_{LANGCODE} set as env variable or otherwise the block won't show up. Check test environment for correct key. Now go to any page and you should see the block rendered with correct language. The language is only used to pass correct api key to the javascript.