Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8293: React & Share renamed to Askem #491

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Apr 5, 2023

UHF-8293

What was done

  • On Cookie Settings page React & Share name is changed to Askem

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8293_RnS_renamed_to_Askem
  • Run make drush-updb drush-cr

How to test

  • Check that React & Share name is not visible on page /cookie-information-and-settings in all languages (FI, EN, SV)
  • Check that code follows our standards

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@xkhaven xkhaven marked this pull request as ready for review April 5, 2023 12:12
Copy link
Contributor

@jeremysteerio jeremysteerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants