Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhf 7766 sote chatapp #414

Merged
merged 7 commits into from
Dec 21, 2022
Merged

Uhf 7766 sote chatapp #414

merged 7 commits into from
Dec 21, 2022

Conversation

Arskiainen
Copy link
Contributor

@Arskiainen Arskiainen commented Dec 16, 2022

UHF-7766

Allow Hester/Sotebot to be used with leijuke just like the watson on housing.
Allow new Virtual Assistants to be used without leijuke after they implement the user consent before loading chat code that might store cookies etc.
Provides user consent functions in window.

What was done

  • Added Sotebot library definition and sotebot chat selection to leijuke. (This needs to be updated once they launch the sotebot.)
  • Added new configurable IBM Chat App block that injects the appropriate script tags.
  • Added user consent functions for chat app to use.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git checkout dev
    • git pull
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-7766-sote-chatapp
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works by adding the appropriate blocks with the appropriate configuration.
  • Check that the user consent functions are available in the window object and they update the cookie consent.
  • Check that code follows our standards.

Other PRs

  • Link to other PR

type: external,
minified: true
}
'https://coh-chat-app-prod.ow6i4n9pdzm.eu-de.codeengine.appdomain.cloud/static/sote/custom.widget.min.js?tenantId=www-hel-fi-prod&assistantId=sote': {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need official ids from IBM.

Comment on lines +5 to +6
retrieveUserConsent: () => (Drupal.eu_cookie_compliance.hasAgreedWithCategory('chat')),
confirmUserConsent: () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User consent functions for IBM to use from their chat app.

@Arskiainen Arskiainen marked this pull request as ready for review December 19, 2022 13:34
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
16.8% 16.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants