Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7008: Fixed broken Drupal core localization URL #402

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 21, 2022

UHF-7008

What was done

  • Fixed broken Drupal core localization URL
  • Moved translations couple of translation from helfi_tpr_config module to helfi_content module
  • Added patches to fix the base field definitions caching in multilingual fields and the rendering of admin toolbar and contextual links when browsing the admin pages in other language than English.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-7008_localization -W
  • Run make drush-updb drush-cr drush-locale-update

How to test

  • Check that the Drupal core translations get loaded without errors when running drush locale:check; drush locale:update; drush cr
  • Log in as helfi-admin and change user language to Finnish
    • Clear caches from "Flush all caches" link and check that the translations are translated to Finnish. Note. There might be issues with the translations still - see more in here UHF-7611
  • Check that code follows our standards

Other PRs

…multilingual fields and the rendering of admin toolbar and contextual links when browsing the admin pages in other language than English.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants