UHF-9712: Fix phpstan

City-of-Helsinki · Mar 12, 2024 · a6eb3fd · a6eb3fd
1 parent 3e1480b
commit a6eb3fd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/helfi_platform_config.tokens.inc b/helfi_platform_config.tokens.inc
@@ -10,6 +10,7 @@ declare(strict_types=1);
 use Drupal\Core\Entity\EntityInterface;
 use Drupal\Core\Language\LanguageInterface;
 use Drupal\Core\Render\BubbleableMetadata;
+use Drupal\paragraphs\ParagraphInterface;
 
 /**
  * Implements hook_token_info().

diff --git a/modules/helfi_platform_config_base/src/Token/NodeImageBuilder.php b/modules/helfi_platform_config_base/src/Token/NodeImageBuilder.php
@@ -58,15 +58,17 @@ public function buildUrl(EntityInterface $entity): ?string {
    * @return \Drupal\file\FileInterface|null
    *   Image entity.
    */
-  public function getImage(NodeInterface $node) : ?FileInterface {
+  private function getImage(NodeInterface $node) : ?FileInterface {
     if (
       $node->hasField('field_liftup_image') &&
       isset($node->field_liftup_image->entity) &&
       $node->field_liftup_image->entity instanceof MediaInterface &&
       $node->field_liftup_image->entity->hasField('field_media_image')
     ) {
       // If liftup image has an image set, use it as the shareable image.
-      return $node->field_liftup_image->entity->field_media_image->entity;
+      $file = $node->field_liftup_image->entity->field_media_image->entity;
+      assert($file instanceof FileInterface);
+      return $file;
     }
     elseif (
       $node->hasField('field_image') &&
@@ -75,7 +77,9 @@ public function getImage(NodeInterface $node) : ?FileInterface {
       $node->field_image->entity->hasField('field_media_image')
     ) {
       // If the node has an image, use that.
-      return $node->field_image->entity->field_media_image->entity;
+      $file = $node->field_image->entity->field_media_image->entity;
+      assert($file instanceof FileInterface);
+      return $file;
     }
     elseif (
       $node->hasField('field_organization') &&
@@ -84,7 +88,9 @@ public function getImage(NodeInterface $node) : ?FileInterface {
     ) {
       // Use the image from the taxonomy term.
       $taxonomy_term = $node->field_organization->entity;
-      return $taxonomy_term->field_default_image->entity;
+      $file = $taxonomy_term->field_default_image->entity;
+      assert($file instanceof FileInterface);
+      return $file;
     }
 
     return NULL;