Reduce API requests by increasing batch size #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tuutti
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
The street data API seems to become sometimes unresponsive while the data is re-indexed in a cron job. This was noticed while looking at the cron pod logs.
Street data indexing makes a request to
https://kartta.hel.fi/ws/geoserver/avoindata/wfsfor each batch of 50 items. Currently, there are enough items for around 150 batches. The indexing happens every 24 hours.This pull request increases the batch size so that the items are processed in around 15 batches. This should decrease the load to the street data API.
How to install
git checkout UHF-X-street-data-errorsmake freshmake drush-crHow to test
bash ./docker/openshift/crons/street-data.sh