Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8975 Paragraph order #781

Merged
merged 4 commits into from
Jan 18, 2024
Merged

UHF-8975 Paragraph order #781

merged 4 commits into from
Jan 18, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jan 16, 2024

UHF-8975

What was done

  • Updated the order for kymp related paragraph types.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Checkout this branch
    • git fetch -all && git checkout UHF-8975_paragraph_order
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8975_paragraph_order
  • Run make drush-cim drush-updb drush-cr

How to test

  • Download the excel file of correct paragraphs orders from https://helsinkisolutionoffice.atlassian.net/browse/UHF-8975
  • Go to add/edit the following entities and check that the paragraphs (in Finnish) are in the same order as in the excel file
    • Landing page
    • Standard page
    • TPR Unit
    • TPR Service
  • Check that code follows our standards

Other PRs

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project and district content types still have old order on the paragraphs. They could follow the basic page rules? 🤔

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima
Copy link
Contributor Author

khalima commented Jan 18, 2024

The project and district content types still have old order on the paragraphs. They could follow the basic page rules? 🤔

These are fixed in aaceb44

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well now, great work!! 🦖

@khalima khalima merged commit 28c625d into dev Jan 18, 2024
1 of 2 checks passed
@khalima khalima deleted the UHF-8975_paragraph_order branch January 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants