Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9196: Update project listing cards to common one #771

Merged
merged 4 commits into from
Jan 2, 2024
Merged

UHF-9196: Update project listing cards to common one #771

merged 4 commits into from
Jan 2, 2024

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Dec 29, 2023 •
edited by jira bot
Loading

UHF-9196

What was done

  • Common card styles taken in use on project listing

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9196_Update_card_style
    • make fresh
  • Run make drush-cr

How to test

  • Project listing page uses common styles for cards. E.g. on page https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne/kaupunkisuunnittelu-ja-rakentaminen/uutta-helsinkia-rakentamassa/keskusta
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go now 🦖

@teroelonen teroelonen merged commit f134f98 into dev Jan 2, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9196_Update_card_style branch January 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkhaven @teroelonen