Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Fix crash on site install #726

Merged
merged 1 commit into from
Nov 15, 2023
Merged

UHF-X: Fix crash on site install #726

merged 1 commit into from
Nov 15, 2023

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Nov 15, 2023 •
edited
Loading

What was done

At the moment, artifact generation fails silently due to module loading order issue. This adds search_api as a dependency to helfi_kymp_content module, so that class Drupal\search_api\Event\SearchApiEvents is present when Drupal\helfi_kymp_content\EventSubscriber\SearchApiSubscriber::getSubscribedEvents is called.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-X-fix-crash-on-site-install
    • make fresh
  • Run make drush-cr

How to test

  • Run commands from artifact.yml
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@hyrsky
Fix site install crash: add search_api as a dependency to helfi_kymp_…
5fb0abb 
…content

search_api module must be present when Drupal\helfi_kymp_content\EventSubscriber\SearchApiSubscriber::getSubscribedEvents()
is called.
@hyrsky hyrsky force-pushed the UHF-X-fix-crash-on-site-install branch from 5ba9687 to 5fb0abb Compare November 15, 2023 10:42
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hyrsky hyrsky changed the title UHF-X: Workaround to fix crash on site install UHF-X: Fix crash on site install Nov 15, 2023
@hyrsky hyrsky marked this pull request as ready for review November 15, 2023 11:02
@hyrsky hyrsky merged commit 47bb2f4 into dev Nov 15, 2023
4 checks passed
@hyrsky hyrsky deleted the UHF-X-fix-crash-on-site-install branch November 15, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrsky @rpnykanen