Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10169: disable ad role mapping #665

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jun 27, 2024

UHF-10169

What was done

Kasko roles comprehensive_school_editor, daycare_editor, playground_editor, school_editor don't have AD role mapping. The tunnistamo module eats roles that are not configured for user on login, so any helsinkiad user that has these roles loses them when they login.

Removing this config should disable the role mapping for now.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10169-disable-ad-role-mapping
    • make fresh
  • Run make drush-cr

How to test

  •  Configure tunnistamo locally
  • Add role to your user: drush user:role:add 'comprehensive_school_editor' --uid <uid for your account>
  • Log in
  • Check that comprehensive_school_editor role is preserved.
  • Check that code follows our standards

Continuous documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

Copy link

@hyrsky hyrsky merged commit e46c8ba into dev Jul 29, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-10169-disable-ad-role-mapping branch July 29, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants