Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9531: Add separate client for edu users #556

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jan 29, 2024

UHF-9531

What was done

  • Add separate client for edu users so we can migrate to keycloak for all other users.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9531-separate-client-for-edu
    • make fresh
  • Run make drush-cr
  • Add TUNNISTAMO_CLIENT_ID, TUNNISTAMO_CLIENT_ID, KEYCLOAK_CLIENT_ID and KEYCLOAK_CLIENT_SECRET variables:
    $config['openid_connect.client.keycloak']['settings']['client_id'] = 'AAA...';
    $config['openid_connect.client.keycloak']['settings']['client_secret'] = 'BBB...';
    $config['openid_connect.client.tunnistamo']['settings']['client_id'] = 'CCC...';
    $config['openid_connect.client.tunnistamo']['settings']['client_secret'] = 'DDD...';

How to test

  • Wait until the new return url /fi/kasvatus-ja-koulutus/openid-connect/keycloak is activated
  • Check that this feature works
  • Check that code follows our standards

Other PRs

  • Link to other PR

@hyrsky hyrsky force-pushed the UHF-9531-separate-client-for-edu branch 2 times, most recently from 9a67c83 to c0cc8af Compare January 30, 2024 08:15
@hyrsky hyrsky force-pushed the UHF-9531-separate-client-for-edu branch from c0cc8af to 9fc1f0f Compare January 30, 2024 08:29
@hyrsky hyrsky marked this pull request as ready for review January 30, 2024 08:29
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyrsky hyrsky merged commit bf49319 into dev Jan 30, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-9531-separate-client-for-edu branch January 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants