Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9107: Unified button placement on filter searches #546

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 16, 2024

UHF-9107

What was done

  • This thing was fixed

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9107
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9107
  • Run make drush-cr

How to test

Designers review

  • This PR has been visually reviewed by a designer (Nina Hiukkanen)

Other PRs

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this search supposed to look like this?
All other searches looks okay in kasko instance.

image

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good, despite of the "municipal daycare centres" search, which looks odd to my 👁️ . 🚀

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All kasko forms looks good now. Good work! 🚀

@teroelonen teroelonen merged commit b4e6082 into dev Jan 23, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9107 branch January 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants