Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9151: add new fields to schools elastic index #487

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Nov 16, 2023

UHF-9151

What was done

  • Add new field to schools elastic index
  • Rename EventSubscriber and add BuildIndexParamsEvent for schools index new fields

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9151-update-comprehensive-school-elastic-index
    • make fresh
  • Run make drush-cr

How to test

  • Run TPR Ontologyword details migration: drush migrate:import tpr_ontology_word_details --update
  • Run TPR Unit migration to update entity references: drush migrate:import tpr_unit --update. This might take a while. You can import only individual TPR unit ID:s if you like. Try comprehensive and high schools and some other TPR units. Should be something like drush migrate:import tpr_unit --idlist=51486,46515
  • Run drush sapi-rt; drush sapi-c; drush sapi-i; drush cr
  • Check that indexing works without errors
  • Go to https://elastic-helfi-kasko.docker.so/schools/_search?q=id:51486 and check that ontologyword_details_clarifications and ontologyword_ids fields have values. Clarifications field might be empty if school doesn't have any Weighted curriculum education
  • Check other indexed items look good: https://elastic-helfi-kasko.docker.so/schools/_search
  • Check that school search work normally: https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/peruskoulut
  • Check that code follows our standards

@dire dire self-requested a review November 16, 2023 13:09
Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked nicely!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jussiles Jussiles merged commit 9ed5589 into dev Nov 17, 2023
3 checks passed
@Jussiles Jussiles deleted the UHF-9151-update-comprehensive-school-elastic-index branch November 17, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants