UHF-8926 #460
Merged
UHF-8926 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et to be same as node tranlation status
…roup menu items to match the node status
tuutti
requested changes
Oct 17, 2023
| /** | ||
| * Update group menu item's content translation status to match node's status. | ||
| */ | ||
| function helfi_group_update_9001() { |
| } | ||
|
|
||
| $node = $node->getTranslation($langcode); | ||
| if ((bool) $menu_item->content_translation_status->value != (bool) $node->isPublished()) { |
There was a problem hiding this comment.
Use strict comparison !==, $node->isPublished() will always return boolean already
| } | ||
|
|
||
| /** | ||
| * Ticket #UHF-8926: submit handler to set menu items translation status. |
There was a problem hiding this comment.
The ticket ID is reduntant here imo, it's already explained in code using this handler.
| /** | ||
| * Implements hook_form_BASE_FORM_ID_alter(). | ||
| * | ||
| * #UHF-8926 Prevent group's MenuContentLink's translation form from crashing |
There was a problem hiding this comment.
I think this comment could be explained better. Something like:
Group menu emits menu parent from entity's translation form. Make sure menu_parent is always set.
| $values = $form_state->getValue('menu'); | ||
| $node = $form_state->getFormObject()->getEntity(); | ||
| $langCode = $node->language()->getId(); | ||
| if (!empty($values['entity_id'])) { |
tuutti
approved these changes
Oct 18, 2023
… in main menu button. use link's translation instead of the default link
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8926
-Prevent white screen while editing group menu item translation
-Node's edit pages "published on main navigation" checkbox now updates based on group's menu content item's content translation status
What was done
Updated group module
Fixed white screen.
Form alter to keep the "content translation status" checkbox on correct state. For group content, the "published in main navigation" state follows the node's published state. Value is updated while saving (not with javascript)
Update hook to update group's menu item's content translation status to match node status.
How to install
git checkout UHF-8926composer require drupal/helfi_navigation:dev-UHF-8926make freshmake drush-crHow to test
Log in as user which is assigned to a group, for example user 19.
Other PRs: