Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-11045: Accessible autocomplete #798

Merged
merged 4 commits into from
Dec 17, 2024
Merged

UHF-11045: Accessible autocomplete #798

merged 4 commits into from
Dec 17, 2024

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 16, 2024 •
edited
Loading

UHF-11045

  • Implement accessible autocomplete

What was done

  • Add @drupal/a11y-autocomplete package
  • Add new element for form api use
  • Add script to make use of the autocomplete
  • Add translations

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout origin/UHF-11045
    • make fresh
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

@jeremysteerio jeremysteerio changed the title Use drupal/a11y-autocomplete to implement an accessible autocomplete … UHF-11045: Accessible autocomplete Dec 16, 2024
@jeremysteerio jeremysteerio marked this pull request as ready for review December 16, 2024 12:39
rpnykanen
rpnykanen approved these changes Dec 17, 2024
View reviewed changes
public/modules/custom/helfi_etusivu/src/Element/HelfiEtusivuAutocomplete.php Outdated
/**
* Autocomplete element for Helsinki near you form.
*
* To be evaluated if this could be used domain-wide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the actual @todo.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jeremysteerio jeremysteerio merged commit bd298d2 into dev Dec 17, 2024
3 checks passed
@jeremysteerio jeremysteerio deleted the UHF-11045 branch December 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysteerio @rpnykanen