Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10554: Prefer english when content does not have translation #704

Merged
merged 1 commit into from
Sep 12, 2024
Merged

UHF-10554: Prefer english when content does not have translation #704

merged 1 commit into from
Sep 12, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Sep 12, 2024 •
edited
Loading

UHF-10554

What was done

  • Prefer english when content does not have translation to current language.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10554
    • make fresh
  • Run make drush-cr

How to test

  • Create an announcement in finnish, then add english translation.
  • Go to /uk, the english announcement should be rendered.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

khalima
khalima approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this and revert if something gets broken. 🚀

@hyrsky hyrsky merged commit 6b0894e into dev Sep 12, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-10554 branch September 12, 2024 12:21
@hyrsky hyrsky mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrsky @khalima