Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10452: Change the front page latest news blocks news archive base url #689

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 23, 2024

NOTICE!

When this PR is merged and deployed to testing the following changes need to be made manually to front page instance:

  • Change the current news archive url to /news/archive / /uutiset/arkisto / /nyheter/arkiv
  • Create a new landing page called Current and have it on the /news / /uutiset / /nyheter path.

UHF-10452

What was done

  • Changed the front page latest news blocks news archive base url to point to /news/archive

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10452
    • make fresh
  • Run make drush-cim drush-cr

How to test

  • Check that the front page latest news paragraphs "see all news" link in English leads to /news/archive url. Remember to check with both minimal and card design.
  • Check that the front page latest news paragraphs "see all news" link in English leads to /uutiset/arkisto url. Remember to check with both minimal and card design.
  • Check that the front page latest news paragraphs "see all news" link in English leads to /nyheter/arkiv url. Remember to check with both minimal and card design.
  • Remember to check the helfi_platform_config PR as well.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to the required files and included in this PR.

Other PRs

Copy link

Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally after creating the pages!

@teroelonen teroelonen merged commit c329694 into dev Aug 27, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-10452 branch August 27, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants