Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10469: Revert news archive from index to database based #683

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 19, 2024

UHF-10469

What was done

  • Change news archive fallback and rss views to use drupal database instead of elastic index to make the rss filtering work correctly

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10469
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10469
  • Run make fresh and I recommend taking latest dump from testing so that the news archive page is there already.
  • You might need to reindex the elastic so you can do that by running this in shell: drush sapi-rt; drush sapi-c; drush sapi-i; drush cr

How to test

  • Go to /news page and filter out the news in some way. Now go to the bottom of the results and click the rss link. Make sure that the results include the same news that you saw when filtering the results (unless there is more than 20 since the rss lists only max 20 items). Check that the same thing works with a bit different set of filters.
  • Next test the same thing with /uutiset and make sure the rss feed still works the same way on Finnish as well.
  • Next test that the feed ALSO works with query parameters like this in the URL: ?tags%5b%5d=375. This should give the same results as the query parameters like this: ?topic[0]=375
  • Make sure that all elements of the archive are translated such as the pager and the RSS feed links.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@teroelonen teroelonen marked this pull request as ready for review August 19, 2024 14:58
Copy link

@juho-lehmonen juho-lehmonen self-requested a review August 20, 2024 06:56
@teroelonen teroelonen merged commit 794e38c into dev Aug 20, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-10469 branch August 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants