Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10364: Stop top articles block from dropping old content away #670

Merged
merged 1 commit into from
Jul 30, 2024
Merged

UHF-10364: Stop top articles block from dropping old content away #670

merged 1 commit into from
Jul 30, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jul 30, 2024 •
edited by jira bot
Loading

UHF-10364

What was done

  • Remove the cron code that removes old news and articles from the top news block
  • Change the top news block with articles to list only 3 articles as it should

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10364
    • make fresh
  • Run make drush-cr

How to test

  • Make sure that news items and articles that were created more than one month ago, still stay promoted on the top news block even if you run cron.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@teroelonen
UHF-10364: Remove the cron code that removes old news and articles fr…
9f551fe 
…om the top news block, change the top news block with articles to list only 3 articles as it should
khalima
khalima approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good find! 🚀

@teroelonen teroelonen merged commit eb14efd into dev Jul 30, 2024
1 check passed
@teroelonen teroelonen deleted the UHF-10364 branch July 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima